Repository navigation
Conversation
EhabY
force-pushed
the
feat/ssh-client-alive-env
branch
from
November 20, 2026 11:26
bc50e01 to
64da3e0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1197, which forwards the session type with
SendEnv.Sends the resolved
ServerAliveIntervalandServerAliveCountMax(fromssh -G, so user overrides apply) to the agent asCODER_SSH_CLIENT_ALIVE_INTERVALandCODER_SSH_CLIENT_ALIVE_COUNT_MAX, added toSendEnv. With coder/coder#32444, the agent closes a connection whose client stopped answering on that schedule, so a window that crashed or lost power no longer shows as "Ongoing" in the connection log for days. VS Code reconnects over a fresh connection after sleep, so closing the dead one loses nothing.The variables are set after
ssh -G, separately fromapplySshEnvironment, which has to stay early because workspace start runs the CLI with that environment. Older agents ignore them and pass them to the session environment.Verification
The new
applyClientAliveEnvironmenttest fails when dispose stops removing its variables.Written with Coder Agents and reviewed by @EhabY.