Skip to content

#26789 Fix auto schema update when schema order has changed. - #26794

Merged
reuvenlax merged 2 commits into
apache:masterfrom
reuvenlax:fix_auto_schema_update_ordering
May 21, 2023
Merged

reuvenlax merged 2 commits into
apache:masterfrom
reuvenlax:fix_auto_schema_update_ordering

Conversation

@reuvenlax

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @manavgarg for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test nested case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in other unit test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this return too aggresive?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - it means that the nested row was incompatible (essentially a field was deleted). In theory we should never hit this of course, since BigQuery should never allow the table to be updated to an incompatible schema.

@reuvenlax
reuvenlax force-pushed the fix_auto_schema_update_ordering branch from 480306b to e8b593a Compare May 20, 2023 07:54
@reuvenlax

Copy link
Copy Markdown
Contributor Author

Run Spotless PreCommit

@reuvenlax

Copy link
Copy Markdown
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@reuvenlax

Copy link
Copy Markdown
Contributor Author

run java precommit

.addFields(
TableFieldSchema.newBuilder().setName("c").setType(TableFieldSchema.Type.STRING))
.addFields(
TableFieldSchema.newBuilder()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more than one layer nested?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added another layer.

@reuvenlax

Copy link
Copy Markdown
Contributor Author

run java precommit

1 similar comment
@reuvenlax

Copy link
Copy Markdown
Contributor Author

run java precommit

@reuvenlax
reuvenlax merged commit ff16639 into apache:master May 21, 2023
riteshghorse pushed a commit to riteshghorse/beam that referenced this pull request May 21, 2023
riteshghorse added a commit that referenced this pull request May 22, 2023
…order has changed. (#26810)

Co-authored-by: reuvenlax <relax@google.com>
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants